Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async generic invoke support. #3637

Closed
wants to merge 2 commits into from
Closed

Async generic invoke support. #3637

wants to merge 2 commits into from

Conversation

carryxyh
Copy link
Member

Fix issue: #3163

Add async support fo generic invocation.

@carryxyh carryxyh requested a review from chickenlj March 12, 2019 03:41
@carryxyh carryxyh mentioned this pull request Mar 12, 2019
Closed
@codecov-io
Copy link

codecov-io commented Mar 12, 2019 •
edited
Loading

Codecov Report

Merging #3637 into master will increase coverage by 0.41%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3637      +/-   ##
============================================
+ Coverage     63.44%   63.86%   +0.41%     
  Complexity       71       71              
============================================
  Files           703      701       -2     
  Lines         31000    30717     -283     
  Branches       5024     4979      -45     
============================================
- Hits          19669    19618      -51     
+ Misses         9066     8839     -227     
+ Partials       2265     2260       -5
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/apache/dubbo/common/Constants.java 93.33% <ø> (ø) 0 <0> (ø) ⬇️
...a/org/apache/dubbo/rpc/service/GenericService.java 0% <0%> (ø) 0 <0> (?)
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java 70.96% <100%> (+2.54%) 0 <0> (ø) ⬇️
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
...pport/zookeeper/ZookeeperDynamicConfiguration.java 72.72% <0%> (-10.61%) 0% <0%> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-8.7%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 78.04% <0%> (-7.32%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bfbc7...9051f80. Read the comment docs.

@chickenlj chickenlj added this to the 2.7.2 milestone Mar 14, 2019
@chickenlj chickenlj mentioned this pull request Mar 14, 2019
Closed
@chickenlj chickenlj closed this May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chickenlj chickenlj Awaiting requested review from chickenlj

Assignees

@chickenlj chickenlj

Labels
None yet
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@carryxyh @codecov-io @chickenlj